Skip to content

Avoid looking at local variables for deprecation warnings #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2025
Merged

Avoid looking at local variables for deprecation warnings #283

merged 3 commits into from
Feb 14, 2025

Conversation

abrookins
Copy link
Collaborator

@abrookins abrookins commented Feb 13, 2025 •
edited
Loading

Deprecation warnings should not be looking at local function variables. 😅

@abrookins abrookins marked this pull request as ready for review February 13, 2025 22:26
justin-cechmanek
justin-cechmanek previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@justin-cechmanek justin-cechmanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

@abrookins abrookins marked this pull request as draft February 13, 2025 23:42
@tylerhutcherson
Copy link
Collaborator

LGTM! Thanks for the fix and wow look at those tests 🥇 👍🏼

@tylerhutcherson tylerhutcherson marked this pull request as ready for review February 14, 2025 12:35
@abrookins abrookins merged commit c54880a into main Feb 14, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerhutcherson tylerhutcherson tylerhutcherson approved these changes

@justin-cechmanek justin-cechmanek justin-cechmanek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abrookins @tylerhutcherson @justin-cechmanek